]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net: drv: netdevsim: don't napi_complete() from netpoll
authorJakub Kicinski <kuba@kernel.org>
Wed, 11 Jun 2025 17:46:43 +0000 (10:46 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 19 Jun 2025 13:32:31 +0000 (15:32 +0200)
commita8ff2e362d901200a1075c3ca9c56d9c7bbef389
treec28bca8710456699b9eac8d589b0bf10c2b056c4
parent073f64c03516bcfaf790f8edc772e0cfb8a84ec3
net: drv: netdevsim: don't napi_complete() from netpoll

[ Upstream commit 1264971017b4d7141352a7fe29021bdfce5d885d ]

netdevsim supports netpoll. Make sure we don't call napi_complete()
from it, since it may not be scheduled. Breno reports hitting a
warning in napi_complete_done():

WARNING: CPU: 14 PID: 104 at net/core/dev.c:6592 napi_complete_done+0x2cc/0x560
  __napi_poll+0x2d8/0x3a0
  handle_softirqs+0x1fe/0x710

This is presumably after netpoll stole the SCHED bit prematurely.

Reported-by: Breno Leitao <leitao@debian.org>
Fixes: 3762ec05a9fb ("netdevsim: add NAPI support")
Tested-by: Breno Leitao <leitao@debian.org>
Link: https://patch.msgid.link/20250611174643.2769263-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/netdevsim/netdev.c