]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
udp: fix behavior of wrong checksums
authorEric Dumazet <edumazet@google.com>
Sat, 30 May 2015 16:16:53 +0000 (09:16 -0700)
committerJiri Slaby <jslaby@suse.cz>
Wed, 10 Jun 2015 09:18:15 +0000 (11:18 +0200)
commita97b54dd69cb05df4c57f5d5b40c761f7835ce4e
tree087dffbc1905e59f1b2c10cdfab57aa18445959b
parent5c3604e1e9d83241bd2255cfb8fac1374d26fc50
udp: fix behavior of wrong checksums

[ Upstream commit beb39db59d14990e401e235faf66a6b9b31240b0 ]

We have two problems in UDP stack related to bogus checksums :

1) We return -EAGAIN to application even if receive queue is not empty.
   This breaks applications using edge trigger epoll()

2) Under UDP flood, we can loop forever without yielding to other
   processes, potentially hanging the host, especially on non SMP.

This patch is an attempt to make things better.

We might in the future add extra support for rt applications
wanting to better control time spent doing a recv() in a hostile
environment. For example we could validate checksums before queuing
packets in socket receive queue.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Willem de Bruijn <willemb@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
net/ipv4/udp.c
net/ipv6/udp.c