]> git.ipfire.org Git - thirdparty/squid.git/commit
Docs: %adapt::sum_trs entries may well exceed %icap::tt (#914)
authorAlex Rousskov <rousskov@measurement-factory.com>
Sat, 30 Oct 2021 11:41:10 +0000 (11:41 +0000)
committerAmos Jeffries <yadij@users.noreply.github.com>
Sat, 27 Nov 2021 05:56:32 +0000 (18:56 +1300)
commita9974383f9fbef51c547485ece3ca38fca5bcc35
tree5a84f2b0fd17022a52ccec0ce190dc6e5cbc9183
parente162fa25fea886e304f7b49c57679cc67a51df78
Docs: %adapt::sum_trs entries may well exceed %icap::tt (#914)

%icap::tt documentation incorrectly implied that the measurement
includes the entire ICAP transaction(s) lifetime. In reality, individual
ICAP transaction contribution stops with
Adaptation::Icap::ModXactLauncher::swanSong(), which is normally
triggered by Adaptation::Icap::Launcher::noteAdaptationAnswer(). Here,
the "answer" does not include the entire ICAP response, but just enough
information to form adapted HTTP message headers (echoed or received).
Thus, a large or slow ICAP response body may result in %adapt::sum_trs
values that far exceed the corresponding %icap::tt "total".

This change does not imply that %icap::tt should (not) work differently.

Also fixed a typo in %adapt::all_trs and polished %adapt::sum_trs docs.
src/cf.data.pre