]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
target: Fix free-after-use regression in PR unregister
authorNicholas Bellinger <nab@linux-iscsi.org>
Thu, 30 Jan 2014 21:08:49 +0000 (13:08 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 22 Feb 2014 21:35:00 +0000 (13:35 -0800)
commita9d3edfa028ff89d8fa6c0121f33d4c2244fa73c
treebe9a073624684320d0042eddbddffbf58c4d795f
parent050d4e1049b17f853ddb1fe1913b4f453faa0100
target: Fix free-after-use regression in PR unregister

commit fc09149df6e20cfbb0bb86f10899607c321a31eb upstream.

This patch addresses a >= v3.11 free-after-use regression
in core_scsi3_emulate_pro_register() that was introduced
in the following commit:

commit bc118fe4c4a8cfa453491ba77c0a146a6d0e73e0
Author: Andy Grover <agrover@redhat.com>
Date:   Thu May 16 10:41:04 2013 -0700

    target: Further refactoring of core_scsi3_emulate_pro_register()

To avoid the free-after-use, save an type value before hand, and
only call core_scsi3_put_pr_reg() with a valid *pr_reg.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Andy Grover <agrover@redhat.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/target/target_core_pr.c