]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
mmc: sdhci-pxav3: set_uhs_signaling is initialized twice differently
authorPeter Griffin <peter.griffin@linaro.org>
Fri, 15 Aug 2014 13:02:15 +0000 (14:02 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 14 Nov 2014 18:10:22 +0000 (10:10 -0800)
commita9ff187a302fd3dbaa377748be45e187fa24d81b
treeb4055e9f87ae538b600ce3140b114046a6ede654
parenta0f9df89576d1ef9490790fb4f1f4756f95f8586
mmc: sdhci-pxav3: set_uhs_signaling is initialized twice differently

commit b315376573778b195e640a163675fb9f5937ddca upstream.

.set_uhs_signaling field is currently initialised twice once to the
arch specific callback pxav3_set_uhs_signaling, and also to the generic
sdhci_set_uhs_signaling callback.

This means that uhs is currently broken for this platform currently, as pxav3
has some special constriants which means it can't use the generic callback.

This happened in
commit 96d7b78cfc2f ("mmc: sdhci: convert sdhci_set_uhs_signaling() into a library function")
commit a702c8abb2a9 ("mmc: host: split up sdhci-pxa, create sdhci-pxav3.c")'

Fix this and hopefully prevent it happening in the future by ensuring named
initialisers always follow the declaration order in the structure definition.

Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/mmc/host/sdhci-pxav3.c