]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ALSA: emu10k1: make E-MU FPGA writes potentially more reliable
authorOswald Buddenhagen <oswald.buddenhagen@gmx.de>
Sun, 28 Apr 2024 09:37:16 +0000 (11:37 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 30 May 2024 07:48:52 +0000 (09:48 +0200)
commitaa27192f78c50eeb3e2a953beb3cd74b10f03963
treeaf53e7c1dc304f61d7a9cf90d5aba7aaecdf89e0
parentcfed8c43a02b8d1ac8c12e0d76e82237eceaee84
ALSA: emu10k1: make E-MU FPGA writes potentially more reliable

[ Upstream commit 15c7e87aa88f0ab2d51c2e2123b127a6d693ca21 ]

We did not delay after the second strobe signal, so another immediately
following access could potentially corrupt the written value.

This is a purely speculative fix with no supporting evidence, but after
taking out the spinlocks around the writes, it seems plausible that a
modern processor could be actually too fast. Also, it's just cleaner to
be consistent.

Signed-off-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Message-ID: <20240428093716.3198666-7-oswald.buddenhagen@gmx.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/pci/emu10k1/io.c