]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ftrace: Check for null ret_stack on profile function graph entry function
authorSteven Rostedt (VMware) <rostedt@goodmis.org>
Thu, 17 Aug 2017 20:37:25 +0000 (16:37 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 30 Aug 2017 08:26:39 +0000 (10:26 +0200)
commitaa2da6c4d548b40f4d6154afd766070bed27ebdb
tree734286d429e9964a01c7d9b593e166a1cfc9c9ab
parent1b8ca8851c252b6d7fc2d7b7c880f6ceb1bec27e
ftrace: Check for null ret_stack on profile function graph entry function

commit a8f0f9e49956a74718874b800251455680085600 upstream.

There's a small race when function graph shutsdown and the calling of the
registered function graph entry callback. The callback must not reference
the task's ret_stack without first checking that it is not NULL. Note, when
a ret_stack is allocated for a task, it stays allocated until the task exits.
The problem here, is that function_graph is shutdown, and a new task was
created, which doesn't have its ret_stack allocated. But since some of the
functions are still being traced, the callbacks can still be called.

The normal function_graph code handles this, but starting with commit
8861dd303c ("ftrace: Access ret_stack->subtime only in the function
profiler") the profiler code references the ret_stack on function entry, but
doesn't check if it is NULL first.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=196611
Fixes: 8861dd303c ("ftrace: Access ret_stack->subtime only in the function profiler")
Reported-by: lilydjwg@gmail.com
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
kernel/trace/ftrace.c