]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net: octeon_ep_vf: fix free_irq dev_id mismatch in IRQ rollback
authorKery Qi <qikeyu2017@gmail.com>
Thu, 8 Jan 2026 16:42:57 +0000 (00:42 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 23 Jan 2026 10:21:17 +0000 (11:21 +0100)
commitaa4c066229b05fc3d3c5f42693d25b1828533b6e
treee876a0f9ae6c7cdc5ccdca66dc31c87f2844191a
parent1b3ed6c512cfd49a46977eccd82c5cc1add0e626
net: octeon_ep_vf: fix free_irq dev_id mismatch in IRQ rollback

[ Upstream commit f93fc5d12d69012788f82151bee55fce937e1432 ]

octep_vf_request_irqs() requests MSI-X queue IRQs with dev_id set to
ioq_vector. If request_irq() fails part-way, the rollback loop calls
free_irq() with dev_id set to 'oct', which does not match the original
dev_id and may leave the irqaction registered.

This can keep IRQ handlers alive while ioq_vector is later freed during
unwind/teardown, leading to a use-after-free or crash when an interrupt
fires.

Fix the error path to free IRQs with the same ioq_vector dev_id used
during request_irq().

Fixes: 1cd3b407977c ("octeon_ep_vf: add Tx/Rx processing and interrupt support")
Signed-off-by: Kery Qi <qikeyu2017@gmail.com>
Link: https://patch.msgid.link/20260108164256.1749-2-qikeyu2017@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c