]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
media: i2c: adv748x: Fix test pattern selection mask
authorNiklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Tue, 21 Jan 2025 20:44:00 +0000 (21:44 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 25 Apr 2025 08:43:35 +0000 (10:43 +0200)
commitaaf8d62abec4eb1620b92a2133bbbc3d1e088f5d
treed8fecdca3accede21cd38c05b8a234b6ea428d81
parentac8d33ae62b650d76965b1bccd3e857cb449001f
media: i2c: adv748x: Fix test pattern selection mask

commit 9e38acacb9d809b97a0bdc5c76e725355a47158a upstream.

The mask to select the test-pattern in register ADV748X_SDP_FRP is
incorrect, it's the lower 3 bits which controls the pattern. The
GENMASK() macro is used incorrectly and the generated mask is 0x0e
instead of 0x07.

The result is that not all test patterns are selectable, and that in
some cases the wrong test pattern is activated. Fix this by correcting
the GENMASK().

Fixes: 3e89586a64df ("media: i2c: adv748x: add adv748x driver")
Cc: stable@vger.kernel.org
Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
[hverkuil: fixed tiny typo in commit log: my -> by]
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/media/i2c/adv748x/adv748x.h