]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
sh: check return code of request_irq
authorNick Desaulniers <ndesaulniers@google.com>
Tue, 22 Dec 2020 20:54:01 +0000 (12:54 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 26 Nov 2021 10:36:21 +0000 (11:36 +0100)
commitab16c0dc7693be43d17dd491438f3dfac86bbb69
tree0f0eab77496166d3e3eb437515536f0907291f05
parente7e70b55af866430efbba64d3450ea060ae45a58
sh: check return code of request_irq

[ Upstream commit 0e38225c92c7964482a8bb6b3e37fde4319e965c ]

request_irq is marked __must_check, but the call in shx3_prepare_cpus
has a void return type, so it can't propagate failure to the caller.
Follow cues from hexagon and just print an error.

Fixes: c7936b9abcf5 ("sh: smp: Hook in to the generic IPI handler for SH-X3 SMP.")
Cc: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: Paul Mundt <lethal@linux-sh.org>
Reported-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Tested-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Reviewed-by: Miguel Ojeda <ojeda@kernel.org>
Signed-off-by: Rich Felker <dalias@libc.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/sh/kernel/cpu/sh4a/smp-shx3.c