]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
riscv: KVM: Fix SBI IPI error generation
authorAndrew Jones <ajones@ventanamicro.com>
Mon, 17 Feb 2025 08:45:10 +0000 (09:45 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 7 Mar 2025 17:25:36 +0000 (18:25 +0100)
commitab306f492c27d6ffaf3eff87ebccbeed2cab66ff
treed2abfe759129b3ebc9a0356712f6b61e615696ae
parentf5009ddfd70af1abea1f97313c6631ae2954395a
riscv: KVM: Fix SBI IPI error generation

[ Upstream commit 0611f78f83c93c000029ab01daa28166d03590ed ]

When an invalid function ID of an SBI extension is used we should
return not-supported, not invalid-param. Also, when we see that at
least one hartid constructed from the base and mask parameters is
invalid, then we should return invalid-param. Finally, rather than
relying on overflowing a left shift to result in zero and then using
that zero in a condition which [correctly] skips sending an IPI (but
loops unnecessarily), explicitly check for overflow and exit the loop
immediately.

Fixes: 5f862df5585c ("RISC-V: KVM: Add v0.1 replacement SBI extensions defined in v0.2")
Signed-off-by: Andrew Jones <ajones@ventanamicro.com>
Reviewed-by: Anup Patel <anup@brainfault.org>
Link: https://lore.kernel.org/r/20250217084506.18763-10-ajones@ventanamicro.com
Signed-off-by: Anup Patel <anup@brainfault.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/riscv/kvm/vcpu_sbi_replace.c