]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
scsi: imm: Fix use-after-free bug caused by unfinished delayed work
authorDuoming Zhou <duoming@zju.edu.cn>
Tue, 28 Oct 2025 10:01:49 +0000 (18:01 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Sat, 29 Nov 2025 20:42:17 +0000 (15:42 -0500)
commitab58153ec64fa3fc9aea09ca09dc9322e0b54a7c
treee824ef2a3527bd7b45a70acb327c6380dd763bb0
parent971bb08704e227a7815fef31713f25c6b25e2599
scsi: imm: Fix use-after-free bug caused by unfinished delayed work

The delayed work item 'imm_tq' is initialized in imm_attach() and
scheduled via imm_queuecommand() for processing SCSI commands.  When the
IMM parallel port SCSI host adapter is detached through imm_detach(),
the imm_struct device instance is deallocated.

However, the delayed work might still be pending or executing
when imm_detach() is called, leading to use-after-free bugs
when the work function imm_interrupt() accesses the already
freed imm_struct memory.

The race condition can occur as follows:

CPU 0(detach thread)   | CPU 1
                       | imm_queuecommand()
                       |   imm_queuecommand_lck()
imm_detach()           |     schedule_delayed_work()
  kfree(dev) //FREE    | imm_interrupt()
                       |   dev = container_of(...) //USE
                           dev-> //USE

Add disable_delayed_work_sync() in imm_detach() to guarantee proper
cancellation of the delayed work item before imm_struct is deallocated.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Duoming Zhou <duoming@zju.edu.cn>
Link: https://patch.msgid.link/20251028100149.40721-1-duoming@zju.edu.cn
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/imm.c