]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net: sched: Fix qdisc_rate_table refcount leak when get tcf_block failed
authorXiyu Yang <xiyuyang19@fudan.edu.cn>
Sun, 29 Aug 2021 15:58:01 +0000 (23:58 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 15 Sep 2021 08:00:54 +0000 (10:00 +0200)
commitab80a2c52b81d586c6520f19b2dbadcd23ffdffb
treec1eece7dedde60bc4e19b66cf12df79cab11a062
parent6b655ec90694727e6744e9d733296b443a5e34ff
net: sched: Fix qdisc_rate_table refcount leak when get tcf_block failed

[ Upstream commit c66070125837900163b81a03063ddd657a7e9bfb ]

The reference counting issue happens in one exception handling path of
cbq_change_class(). When failing to get tcf_block, the function forgets
to decrease the refcount of "rtab" increased by qdisc_put_rtab(),
causing a refcount leak.

Fix this issue by jumping to "failure" label when get tcf_block failed.

Fixes: 6529eaba33f0 ("net: sched: introduce tcf block infractructure")
Signed-off-by: Xiyu Yang <xiyuyang19@fudan.edu.cn>
Reviewed-by: Cong Wang <cong.wang@bytedance.com>
Link: https://lore.kernel.org/r/1630252681-71588-1-git-send-email-xiyuyang19@fudan.edu.cn
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/sched/sch_cbq.c