]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
drm/nouveau: fix reversed error cleanup order in ucopy functions
authorJunrui Luo <moonafterrain@outlook.com>
Wed, 10 Jun 2026 10:01:28 +0000 (18:01 +0800)
committerDanilo Krummrich <dakr@kernel.org>
Sun, 21 Jun 2026 13:15:23 +0000 (15:15 +0200)
commitab99ead646b1b833ecd57fe577a2816f2e848167
tree50372bf32a8bff23ac999bb55606b68f4a6f8d5d
parentc3027973f692077a1b66a9fb26d6a7c46c0dc72c
drm/nouveau: fix reversed error cleanup order in ucopy functions

nouveau_uvmm_vm_bind_ucopy() and nouveau_exec_ucopy() place their error
cleanup labels in allocation order rather than reverse allocation order.
On a u_memcpya() failure for in_sync.s, the goto to err_free_ops (or
err_free_pushs) frees the first allocation and then falls through to
err_free_ins, which calls u_free() on args->in_sync.s.

Since args->in_sync.s still holds the ERR_PTR returned by the failed
u_memcpya(), and ERR_PTR values are not caught by ZERO_OR_NULL_PTR(),
kvfree() proceeds to dereference it, which can result in a kernel oops.
A failure for out_sync.s instead jumps to err_free_ins and skips freeing
the first allocation, leading to a memory leak.

Fix by swapping the cleanup label order so resources are freed in the
correct reverse allocation sequence.

Fixes: b88baab82871 ("drm/nouveau: implement new VM_BIND uAPI")
Reported-by: Yuhao Jiang <danisjiang@gmail.com>
Cc: stable@vger.kernel.org
Signed-off-by: Junrui Luo <moonafterrain@outlook.com>
Link: https://patch.msgid.link/SYBPR01MB7881484D91A6F80271415F71AF1A2@SYBPR01MB7881.ausprd01.prod.outlook.com
Signed-off-by: Danilo Krummrich <dakr@kernel.org>
drivers/gpu/drm/nouveau/nouveau_exec.c
drivers/gpu/drm/nouveau/nouveau_uvmm.c