]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ext4: lock i_mutex when truncating orphan inodes
authorTheodore Ts'o <tytso@mit.edu>
Thu, 27 Dec 2012 06:42:48 +0000 (01:42 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 17 Jan 2013 16:46:23 +0000 (08:46 -0800)
commitab9f12650d4b035cf2e1e72fbb9cda45ed96b08c
tree255b2e1afa14569ce917a14602815de20d62f170
parent764df5435c448302d14c1fff0d80bf7af8aa5289
ext4: lock i_mutex when truncating orphan inodes

commit 721e3eba21e43532e438652dd8f1fcdfce3187e7 upstream.

Commit c278531d39 added a warning when ext4_flush_unwritten_io() is
called without i_mutex being taken.  It had previously not been taken
during orphan cleanup since races weren't possible at that point in
the mount process, but as a result of this c278531d39, we will now see
a kernel WARN_ON in this case.  Take the i_mutex in
ext4_orphan_cleanup() to suppress this warning.

Reported-by: Alexander Beregalov <a.beregalov@gmail.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Reviewed-by: Zheng Liu <wenqing.lz@taobao.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/ext4/super.c