]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
can: pch_can: pch_can_rx_normal: fix use after free
authorVincent Mailhol <mailhol.vincent@wanadoo.fr>
Tue, 23 Nov 2021 11:16:54 +0000 (20:16 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 14 Dec 2021 13:49:01 +0000 (14:49 +0100)
commitabb4eff3dcd2e583060082a18a8dbf31f02689d4
tree8062d64d5e4b4968bfee4da0b6ae8c3b82aaecd0
parent291a164ac1f3b8c92469b39ee9a2202d52088418
can: pch_can: pch_can_rx_normal: fix use after free

commit 94cddf1e9227a171b27292509d59691819c458db upstream.

After calling netif_receive_skb(skb), dereferencing skb is unsafe.
Especially, the can_frame cf which aliases skb memory is dereferenced
just after the call netif_receive_skb(skb).

Reordering the lines solves the issue.

Fixes: b21d18b51b31 ("can: Topcliff: Add PCH_CAN driver.")
Link: https://lore.kernel.org/all/20211123111654.621610-1-mailhol.vincent@wanadoo.fr
Cc: stable@vger.kernel.org
Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/can/pch_can.c