]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
mtd: rawnand: Fix return value check of wait_for_completion_timeout
authorMiaoqian Lin <linmq006@gmail.com>
Tue, 12 Apr 2022 08:34:31 +0000 (08:34 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 12 May 2022 10:20:21 +0000 (12:20 +0200)
commitabe55c894249e5fca4a0356dd519ea38de6586a7
tree6ed830c1ac9a4eb5c7fdeb928479c08a78262266
parent3fc2c30a6a6347493b2a2589cfedd9d8998b4f5f
mtd: rawnand: Fix return value check of wait_for_completion_timeout

[ Upstream commit 084c16ab423a8890121b902b405823bfec5b4365 ]

wait_for_completion_timeout() returns unsigned long not int.
It returns 0 if timed out, and positive if completed.
The check for <= 0 is ambiguous and should be == 0 here
indicating timeout which is the only error case.

Fixes: 83738d87e3a0 ("mtd: sh_flctl: Add DMA capabilty")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20220412083435.29254-1-linmq006@gmail.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/mtd/nand/raw/sh_flctl.c