]> git.ipfire.org Git - thirdparty/libvirt.git/commit
libxl: don't set hasManagedSave when performing save
authorJim Fehlig <jfehlig@suse.com>
Mon, 14 May 2018 20:45:05 +0000 (14:45 -0600)
committerJim Fehlig <jfehlig@suse.com>
Tue, 15 May 2018 17:03:04 +0000 (11:03 -0600)
commitac4a12db715cdb764281cdb89cabd478f8ec9d09
tree501d7e1e41860f14722e483c26ae194ef6831471
parentf50ad2ff63bfa91d438100114baca142afddf301
libxl: don't set hasManagedSave when performing save

libxlDoDomainSave() is used in both the save and managedsave code
paths but was unconditionally setting hasManagedSave to true on
success. As a result, undefine would fail after a non-managed
save/restore operation. E.g.

virsh define; virsh start
virsh save; virsh restore
virsh shutdown
virsh undefine
error: Refusing to undefine while domain managed save image exists

Modify libxlDoDomainSave() to take an additional parameter to
specify managed vs non-managed save, and change callers to use it.

Signed-off-by: Jim Fehlig <jfehlig@suse.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
src/libxl/libxl_driver.c