]> git.ipfire.org Git - thirdparty/linux.git/commit
tracing/fprobe: Roll back on enable_trace_fprobe() failure
authorRaushan Patel <raushan.jhon@gmail.com>
Fri, 24 Jul 2026 06:42:08 +0000 (12:12 +0530)
committerMasami Hiramatsu (Google) <mhiramat@kernel.org>
Tue, 28 Jul 2026 15:27:52 +0000 (00:27 +0900)
commitaca0cd1bf16574327ef64f3178e5f5e37a61ef0b
tree1f7347a6e47609e53b7273bd0cf5d1c094fc284e
parent00a8ce2a2a9fa17674e1feec4d9105c1a5d6a419
tracing/fprobe: Roll back on enable_trace_fprobe() failure

enable_trace_fprobe() sets the file link or the TP_FLAG_PROFILE flag and
then registers each trace_fprobe in the probe list. If
__register_trace_fprobe() fails partway through, the function returns
immediately without unregistering the trace_fprobes it already registered
or undoing the file link / flag it set, leaving the event half-enabled and
leaking the registered fprobe(s).

enable_trace_kprobe() already handles this with a rollback path. Do the
same for fprobe: on failure, unregister all probes and clear the file link
or profile flag.

Link: https://lore.kernel.org/all/20260724064208.480030-1-raushan.jhon@gmail.com/
Fixes: 334e5519c375 ("tracing/probes: Add fprobe events for tracing function entry and exit.")
Cc: stable@vger.kernel.org
Signed-off-by: Raushan Patel <raushan.jhon@gmail.com>
Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
kernel/trace/trace_fprobe.c