]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ipmi:ssif: Check for NULL msg when handling events and messages
authorCorey Minyard <cminyard@mvista.com>
Fri, 1 Apr 2022 12:44:53 +0000 (07:44 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 14 Jun 2022 14:59:16 +0000 (16:59 +0200)
commitaca1b19df1f90cca91b1a1cdf48519915143a476
tree955ab250bfac93dccfc5b717284f14803040daf1
parenta4d4e55e34079bc72fbf2f63e9babcf67f8fe195
ipmi:ssif: Check for NULL msg when handling events and messages

[ Upstream commit 7602b957e2404e5f98d9a40b68f1fd27f0028712 ]

Even though it's not possible to get into the SSIF_GETTING_MESSAGES and
SSIF_GETTING_EVENTS states without a valid message in the msg field,
it's probably best to be defensive here and check and print a log, since
that means something else went wrong.

Also add a default clause to that switch statement to release the lock
and print a log, in case the state variable gets messed up somehow.

Reported-by: Haowen Bai <baihaowen@meizu.com>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/char/ipmi/ipmi_ssif.c