]> git.ipfire.org Git - thirdparty/openvpn.git/commit
Fix unintialized variable in plugin_vlog()
authorSteffan Karger <steffan@karger.me>
Sun, 8 Nov 2015 12:04:27 +0000 (13:04 +0100)
committerGert Doering <gert@greenie.muc.de>
Sun, 8 Nov 2015 14:14:09 +0000 (15:14 +0100)
commitacc74694293b85dd9d8ef129c068b8ce5058dee1
treea90d35abdd2fb12baa8c0e1dfa8cfc8915e29d76
parent0d4ba251879c702b9474e26ff73a4f559d922d4f
Fix unintialized variable in plugin_vlog()

Does not seem to be a problem in normal usage, because one of the PLOG_ERR,
PLOG_WARN, PLOG_NOTE or PLOG_DEBUG will be set, and will cause msg_flags
to be initialized.  In the worst case, msg_flags might accidentally
end up having M_FATAL set, causing openvpn to exit.

This was previously fixed in the master branch (5ead2ae0), but was not
backported to release/2.3, probably because that commit fixed other parts
of the code too, and those parts are quite different between master and
release/2.3.

Re-discovered by coverity.

Signed-off-by: Steffan Karger <steffan@karger.me>
Acked-by: Gert Doering <gert@greenie.muc.de>
Message-Id: <1446984267-3323-1-git-send-email-steffan@karger.me>
URL: http://article.gmane.org/gmane.network.openvpn.devel/10450
Signed-off-by: Gert Doering <gert@greenie.muc.de>
src/openvpn/plugin.c