]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
net_sched: sch_fq: tweak unlikely() hints in fq_dequeue()
authorEric Dumazet <edumazet@google.com>
Tue, 3 Feb 2026 21:47:16 +0000 (21:47 +0000)
committerJakub Kicinski <kuba@kernel.org>
Thu, 5 Feb 2026 04:43:40 +0000 (20:43 -0800)
commitacd21dd2da198875e0cf73f08b18c9bbf8b87d8c
treef449eb1a44cf53e793ac30331fc900142fcaa168
parentf8a062b25586675dd82620735387063a838aa71f
net_sched: sch_fq: tweak unlikely() hints in fq_dequeue()

After 076433bd78d7 ("net_sched: sch_fq: add fast path
for mostly idle qdisc") we need to remove one unlikely()
because q->internal holds all the fast path packets.

       skb = fq_peek(&q->internal);
       if (unlikely(skb)) {
                q->internal.qlen--;

Calling INET_ECN_set_ce() is very unlikely.

These changes allow fq_dequeue_skb() to be (auto)inlined,
thus making fq_dequeue() faster.

$ scripts/bloat-o-meter -t vmlinux.0 vmlinux
add/remove: 2/2 grow/shrink: 0/1 up/down: 283/-269 (14)
Function                                     old     new   delta
INET_ECN_set_ce                                -     267    +267
__pfx_INET_ECN_set_ce                          -      16     +16
__pfx_fq_dequeue_skb                          16       -     -16
fq_dequeue_skb                               103       -    -103
fq_dequeue                                  1685    1535    -150
Total: Before=24886569, After=24886583, chg +0.00%

Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Jamal Hadi Salim <jhs@mojatatu.com>
Link: https://patch.msgid.link/20260203214716.880853-1-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/sched/sch_fq.c