]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net: phy: dp83869: fix memory corruption when enabling fiber
authorIngo van Lil <inguin@gmx.de>
Wed, 2 Oct 2024 16:18:07 +0000 (18:18 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 17 Oct 2024 13:11:54 +0000 (15:11 +0200)
commitad0d76b8ee5db063791cc2e7a30ffc9852ac37c4
treec673627ece6516597396b29ed4281760fa96f36d
parent584c019baedddec3fd634053e8fb2d8836108d38
net: phy: dp83869: fix memory corruption when enabling fiber

[ Upstream commit a842e443ca8184f2dc82ab307b43a8b38defd6a5 ]

When configuring the fiber port, the DP83869 PHY driver incorrectly
calls linkmode_set_bit() with a bit mask (1 << 10) rather than a bit
number (10). This corrupts some other memory location -- in case of
arm64 the priv pointer in the same structure.

Since the advertising flags are updated from supported at the end of the
function the incorrect line isn't needed at all and can be removed.

Fixes: a29de52ba2a1 ("net: dp83869: Add ability to advertise Fiber connection")
Signed-off-by: Ingo van Lil <inguin@gmx.de>
Reviewed-by: Alexander Sverdlin <alexander.sverdlin@siemens.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/20241002161807.440378-1-inguin@gmx.de
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/phy/dp83869.c