]> git.ipfire.org Git - thirdparty/libvirt.git/commit
tests: domcaps: Remove 'full' test
authorCole Robinson <crobinso@redhat.com>
Tue, 19 Feb 2019 17:52:30 +0000 (12:52 -0500)
committerCole Robinson <crobinso@redhat.com>
Mon, 18 Mar 2019 14:51:02 +0000 (10:51 -0400)
commitad129324814dd4fc4804e2c3744bed0b877a020a
tree182eafd6ef831fa6d8a0a6a913a8eececc160dcf
parent0b89ef55968f6a98965787cec3602e9ab933156b
tests: domcaps: Remove 'full' test

The 'full' test verifies the output of a virDomainCapsPtr built
by hand. It has the following problems:

The domcaps test suite nowadays has 3 hypervisor driver implementations
which should give us plenty of opportunity to get full domcaps coverage.
I don't think this test has much value. And it has the following issues:

- Requires manual intervention to test new domcaps XML, which is easy
  to miss, for example gic bits aren't covered there.
- The SET_ALL_BITS trick it uses to fill in enums will output
  values that are never reported by any driver implementation
  (strings like 'default')

Let's remove it

Acked-by: Michal Privoznik <mprivozn@redhat.com>
Signed-off-by: Cole Robinson <crobinso@redhat.com>
tests/domaincapsschemadata/full.xml [deleted file]
tests/domaincapstest.c