]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
NFSD: Clear TIME_DELEG in the suppattr_exclcreat bitmap
authorChuck Lever <chuck.lever@oracle.com>
Mon, 17 Nov 2025 16:00:50 +0000 (11:00 -0500)
committerChuck Lever <chuck.lever@oracle.com>
Thu, 18 Dec 2025 16:18:39 +0000 (11:18 -0500)
commitad3cbbb0c1892c48919727fcb8dec5965da8bacb
tree1ddcb43155f11cbc451c243499b5b7848fe671ad
parent27d17641cacfedd816789b75d342430f6b912bd2
NFSD: Clear TIME_DELEG in the suppattr_exclcreat bitmap

>From RFC 8881:

5.8.1.14. Attribute 75: suppattr_exclcreat

> The bit vector that would set all REQUIRED and RECOMMENDED
> attributes that are supported by the EXCLUSIVE4_1 method of file
> creation via the OPEN operation. The scope of this attribute
> applies to all objects with a matching fsid.

There's nothing in RFC 8881 that states that suppattr_exclcreat is
or is not allowed to contain bits for attributes that are clear in
the reported supported_attrs bitmask. But it doesn't make sense for
an NFS server to indicate that it /doesn't/ implement an attribute,
but then also indicate that clients /are/ allowed to set that
attribute using OPEN(create) with EXCLUSIVE4_1.

The FATTR4_WORD2_TIME_DELEG attributes are also not to be allowed
for OPEN(create) with EXCLUSIVE4_1. It doesn't make sense to set
a delegated timestamp on a new file.

Fixes: 7e13f4f8d27d ("nfsd: handle delegated timestamps in SETATTR")
Cc: stable@vger.kernel.org
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfsd/nfsd.h