]> git.ipfire.org Git - thirdparty/libvirt.git/commit
conf: Use correct type for balloon stats period
authorMartin Kletzander <mkletzan@redhat.com>
Fri, 13 Mar 2015 16:08:15 +0000 (17:08 +0100)
committerMartin Kletzander <mkletzan@redhat.com>
Tue, 17 Mar 2015 11:06:14 +0000 (12:06 +0100)
commitad69e8be4a7592c68174a7c0d8b07a2c392ea336
tree863e7fbf133f650686f74a6cab22bf4763c43080
parent4fca30e0bde012d68e4abed325f7524705f82027
conf: Use correct type for balloon stats period

We're parsing memballoon status period as unsigned int, but when we're
trying to set it, both we and qemu use signed int.  That means large
values will get wrapped around to negative one resulting in error.
Basically the same problem as commit e3a7b874 was dealing with when
updating live domain.

QEMU changed the accepted value to int64 in commit 1f9296b5, but even
values as INT_MAX don't make sense since the value passed means seconds.
Hence adding capability flag for this change isn't worth it.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1140958

Signed-off-by: Luyao Huang <lhuang@redhat.com>
Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
docs/formatdomain.html.in
src/conf/domain_conf.c
src/conf/domain_conf.h
src/qemu/qemu_process.c