]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix ALTER TABLE .. ADD COLUMN with complex inheritance trees
authorMichael Paquier <michael@paquier.xyz>
Wed, 24 Jan 2024 05:20:10 +0000 (14:20 +0900)
committerMichael Paquier <michael@paquier.xyz>
Wed, 24 Jan 2024 05:20:10 +0000 (14:20 +0900)
commitad6fbbeeb07aa40dd3a90b417c0820543d8626eb
tree0833519e33de37a02030524e269b213fac87aa0d
parent3fd36be52b70b95eea6fe7d296ce871f49eedb50
Fix ALTER TABLE .. ADD COLUMN with complex inheritance trees

This command, when used to add a column on a parent table with a complex
inheritance tree, tried to update multiple times the same tuple in
pg_attribute for a child table when incrementing attinhcount, causing
failures with "tuple already updated by self" because of a missing
CommandCounterIncrement() between two updates.

This exists for a rather long time, so backpatch all the way down.

Reported-by: Alexander Lakhin
Author: Tender Wang
Reviewed-by: Richard Guo
Discussion: https://postgr.es/m/18297-b04cd83a55b51e35@postgresql.org
Backpatch-through: 12
src/backend/commands/tablecmds.c
src/test/regress/expected/inherit.out
src/test/regress/sql/inherit.sql