]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
jbd2: remove wrong sb->s_sequence check
authorJan Kara <jack@suse.cz>
Thu, 6 Feb 2025 09:46:58 +0000 (10:46 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 2 May 2025 05:44:03 +0000 (07:44 +0200)
commitad926f735b4d4f10768fec7d080cadeb6d075cac
tree93f1b19aeb7bb30f88dd4e779efd61c812a8ff85
parent3ba402610843d7d15c7f3966a461deeeaff7fba4
jbd2: remove wrong sb->s_sequence check

commit e6eff39dd0fe4190c6146069cc16d160e71d1148 upstream.

Journal emptiness is not determined by sb->s_sequence == 0 but rather by
sb->s_start == 0 (which is set a few lines above). Furthermore 0 is a
valid transaction ID so the check can spuriously trigger. Remove the
invalid WARN_ON.

CC: stable@vger.kernel.org
Signed-off-by: Jan Kara <jack@suse.cz>
Reviewed-by: Zhang Yi <yi.zhang@huawei.com>
Link: https://patch.msgid.link/20250206094657.20865-3-jack@suse.cz
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/jbd2/journal.c