]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
sparc64: Do not disable interrupts in nmi_cpu_busy()
authorDavid S. Miller <davem@davemloft.net>
Tue, 12 Aug 2014 03:45:01 +0000 (20:45 -0700)
committerJiri Slaby <jslaby@suse.cz>
Fri, 31 Oct 2014 14:05:01 +0000 (15:05 +0100)
commitadb54d2a80797cbcc639217ec3eb2315faecb687
tree78d5fb93ec31de6f2df9cda61d593254ed1dd08f
parent53784254d9657ed4c643e755ec1c574a6a43410f
sparc64: Do not disable interrupts in nmi_cpu_busy()

[ Upstream commit 58556104e9cd0107a7a8d2692cf04ef31669f6e4 ]

nmi_cpu_busy() is a SMP function call that just makes sure that all of the
cpus are spinning using cpu cycles while the NMI test runs.

It does not need to disable IRQs because we just care about NMIs executing
which will even with 'normal' IRQs disabled.

It is not legal to enable hard IRQs in a SMP cross call, in fact this bug
triggers the BUG check in irq_work_run_list():

BUG_ON(!irqs_disabled());

Because now irq_work_run() is invoked from the tail of
generic_smp_call_function_single_interrupt().

Signed-off-by: David S. Miller <davem@davemloft.net>
arch/sparc/kernel/nmi.c