]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
scsi: lpfc: Check for hdwq null ptr when cleaning up lpfc_vport structure
authorJustin Tee <justin.tee@broadcom.com>
Wed, 18 Jun 2025 19:21:28 +0000 (12:21 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 28 Aug 2025 14:26:00 +0000 (16:26 +0200)
commitadd68606a01dcccf18837a53e85b85caf0693b4b
treeeea6e748b4101c32ade0d2942351c9d14a3a9298
parent0b424a5bffd71272c1cd0b58a1e6daebebf37558
scsi: lpfc: Check for hdwq null ptr when cleaning up lpfc_vport structure

[ Upstream commit 6698796282e828733cde3329c887b4ae9e5545e9 ]

If a call to lpfc_sli4_read_rev() from lpfc_sli4_hba_setup() fails, the
resultant cleanup routine lpfc_sli4_vport_delete_fcp_xri_aborted() may
occur before sli4_hba.hdwqs are allocated.  This may result in a null
pointer dereference when attempting to take the abts_io_buf_list_lock for
the first hardware queue.  Fix by adding a null ptr check on
phba->sli4_hba.hdwq and early return because this situation means there
must have been an error during port initialization.

Signed-off-by: Justin Tee <justin.tee@broadcom.com>
Link: https://lore.kernel.org/r/20250618192138.124116-4-justintee8345@gmail.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/scsi/lpfc/lpfc_scsi.c