]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
um: tty: Fix handling of close in tty lines
authorAnton Ivanov <anton.ivanov@cambridgegreys.com>
Mon, 7 Dec 2020 17:19:39 +0000 (17:19 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 30 Dec 2020 10:26:04 +0000 (11:26 +0100)
commitadddeb0ed1683d3880f182f25d7fbbace49c00e6
treebf3e94d9573976acaed02d2af8f248e93edf0647
parent4629c75cb1e5476ae84ecd10aea2d5ec09c0695c
um: tty: Fix handling of close in tty lines

[ Upstream commit 9b1c0c0e25dcccafd30e7d4c150c249cc65550eb ]

Fix a logical error in tty reading. We get 0 and errno == EAGAIN
on the first attempt to read from a closed file descriptor.

Compared to that a true EAGAIN is EAGAIN and -1.

If we check errno for EAGAIN first, before checking the return
value we miss the fact that the descriptor is closed.

This bug is as old as the driver. It was not showing up with
the original POLL based IRQ controller, because it was
producing multiple events. Switching to EPOLL unmasked it.

Fixes: ff6a17989c08 ("Epoll based IRQ controller")
Signed-off-by: Anton Ivanov <anton.ivanov@cambridgegreys.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/um/drivers/chan_user.c