]> git.ipfire.org Git - thirdparty/postgresql.git/commit
BRIN: be more strict about required support procs
authorÁlvaro Herrera <alvherre@alvh.no-ip.org>
Tue, 11 Mar 2025 11:50:35 +0000 (12:50 +0100)
committerÁlvaro Herrera <alvherre@alvh.no-ip.org>
Tue, 11 Mar 2025 11:50:35 +0000 (12:50 +0100)
commitade976f8b48193c7d57f475033d60bc5fa185a4a
tree4dc1c850ad2f0841ae2d938f6f1648c12eae4ee6
parentf1ef111a0940fedace997fe740fb221b068cf6ee
BRIN: be more strict about required support procs

With improperly defined operator classes, it's possible to get a
Postgres crash because we'd try to invoke a procedure that doesn't
exist.  This is because the code is being a bit too trusting that the
opclass is correctly defined.  Add some ereport(ERROR)s for cases where
mandatory support procedures are not defined, transforming the crashes
into errors.

The particular case that was reported is an incomplete opclass in
PostGIS.

Backpatch all the way down to 13.

Reported-by: Tobias Wendorff <tobias.wendorff@tu-dortmund.de>
Diagnosed-by: David Rowley <dgrowleyml@gmail.com>
Reviewed-by: Tomas Vondra <tomas@vondra.me>
Discussion: https://postgr.es/m/fb6d9a35-6c8e-4869-af80-0a4944a793a4@tu-dortmund.de
src/backend/access/brin/brin_bloom.c
src/backend/access/brin/brin_inclusion.c
src/backend/access/brin/brin_minmax_multi.c