]> git.ipfire.org Git - thirdparty/bind9.git/commit
Do not overwrite cache dumps
authorMichał Kępień <michal@isc.org>
Tue, 20 Feb 2018 12:59:27 +0000 (13:59 +0100)
committerMichał Kępień <michal@isc.org>
Tue, 20 Feb 2018 12:59:27 +0000 (13:59 +0100)
commitaeea1faf0191f8f693393ee088272f893fc4faa1
tree2e60e59eecc5e534aa6740f2bcba81aa146bdfb0
parent01de79b332ec3fbd0960dc9f4ab9a650ae85d453
Do not overwrite cache dumps

Unless configured otherwise in named.conf, "rndc dumpdb" causes a cache
dump to be written to a file called "named_dump.db" in the working
directory of the given named instance.  Repeatedly using this command
throughout different checks in the cacheclean system test causes cache
dumps for older checks to be overwritten, which hinders failure
diagnosis.  Prevent this by moving each cache dump to a check-specific
location after running "rndc dumpdb".

Furthermore, during the "check flushtree clears adb correctly" check,
dump_cache() is called twice without renaming the resulting files.
Prevent the first cache dump from being overwritten by moving it to a
different file before calling "rndc dumpdb" for the second time.
bin/tests/system/cacheclean/clean.sh
bin/tests/system/cacheclean/tests.sh