]> git.ipfire.org Git - thirdparty/linux.git/commit
media: gspca: Add bounds checking to firmware parser
authorDan Carpenter <dan.carpenter@linaro.org>
Wed, 28 May 2025 20:22:14 +0000 (23:22 +0300)
committerHans Verkuil <hverkuil@xs4all.nl>
Tue, 17 Jun 2025 08:35:15 +0000 (10:35 +0200)
commitaef89c0b2417da79cb2062a95476288f9f203ab0
tree831a8db342cff80a67fc2aea6ff069813093e523
parentd8fbfcab95ffab466aba475127ae677a4c7160fb
media: gspca: Add bounds checking to firmware parser

This sd_init() function reads the firmware.  The firmware data holds a
series of records and the function reads each record and sends the data
to the device.  The request_ihex_firmware() function
calls ihex_validate_fw() which ensures that the total length of all the
records won't read out of bounds of the fw->data[].

However, a potential issue is if there is a single very large
record (larger than PAGE_SIZE) and that would result in memory
corruption.  Generally we trust the firmware, but it's always better to
double check.

Fixes: 49b61ec9b5af ("[media] gspca: Add new vicam subdriver")
Cc: stable@vger.kernel.org
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
drivers/media/usb/gspca/vicam.c