]> git.ipfire.org Git - thirdparty/linux.git/commit
net/sched: cls_u32: validate offshift to prevent shift-out-of-bounds
authorCen Zhang (Microsoft) <blbllhy@gmail.com>
Thu, 23 Jul 2026 04:49:55 +0000 (00:49 -0400)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 28 Jul 2026 09:18:58 +0000 (11:18 +0200)
commitaef96eead2860cbfa371e4471d4f04412213b958
tree3480470d417b31fa210ca15c8074fd1ff1f3fe40
parent295dd295e2137e10e9a5b1891d97e0f08de76f03
net/sched: cls_u32: validate offshift to prevent shift-out-of-bounds

u32_change() copies the user-provided tc_u32_sel.offshift (unsigned char,
0-255) into the kernel knode object without bounds validation. When a
packet later hits u32_classify() with TC_U32_VAROFFSET set, it evaluates
`ntohs(offmask & *data) >> offshift` where the left operand is a 16-bit
value promoted to a 32-bit int. Any offshift >= 32 is undefined behavior
per C11 6.5.7p3, triggerable by an unprivileged user via user/network
namespaces.

UBSAN: shift-out-of-bounds in net/sched/cls_u32.c:236:43
shift exponent 32 is too large for 32-bit type int

Fix this by rejecting offshift >= 16 during filter creation in
u32_change().

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Reported-by: AutonomousCodeSecurity@microsoft.com
Link: https://lore.kernel.org/all/20260720034514.23053-1-blbllhy@gmail.com
Signed-off-by: Cen Zhang (Microsoft) <blbllhy@gmail.com>
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
Tested-by: Jamal Hadi Salim <jhs@mojatatu.com>
Tested-by: Victor Nogueira <victor@mojatatu.com>
Link: https://patch.msgid.link/20260723044955.89471-1-blbllhy@gmail.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
net/sched/cls_u32.c