]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
x86, relocs: Ignore relocations in .notes section
authorKees Cook <keescook@chromium.org>
Tue, 27 Feb 2024 17:51:12 +0000 (09:51 -0800)
committerSasha Levin <sashal@kernel.org>
Tue, 26 Mar 2024 22:19:35 +0000 (18:19 -0400)
commitaf2a9f98d884205145fd155304a6955822ccca1c
tree94350fd6ccb977bc64545c62aa08f3068f03dc9f
parent1cbdc6f36850e091e6604862d74e106ddaed08fe
x86, relocs: Ignore relocations in .notes section

[ Upstream commit aaa8736370db1a78f0e8434344a484f9fd20be3b ]

When building with CONFIG_XEN_PV=y, .text symbols are emitted into
the .notes section so that Xen can find the "startup_xen" entry point.
This information is used prior to booting the kernel, so relocations
are not useful. In fact, performing relocations against the .notes
section means that the KASLR base is exposed since /sys/kernel/notes
is world-readable.

To avoid leaking the KASLR base without breaking unprivileged tools that
are expecting to read /sys/kernel/notes, skip performing relocations in
the .notes section. The values readable in .notes are then identical to
those found in System.map.

Reported-by: Guixiong Wei <guixiongwei@gmail.com>
Closes: https://lore.kernel.org/all/20240218073501.54555-1-guixiongwei@gmail.com/
Fixes: 5ead97c84fa7 ("xen: Core Xen implementation")
Fixes: da1a679cde9b ("Add /sys/kernel/notes")
Reviewed-by: Juergen Gross <jgross@suse.com>
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/x86/tools/relocs.c