]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
cpufreq: qcom-hw: add CONFIG_COMMON_CLK dependency
authorArnd Bergmann <arnd@arndb.de>
Thu, 15 Feb 2024 08:33:14 +0000 (09:33 +0100)
committerSasha Levin <sashal@kernel.org>
Tue, 26 Mar 2024 22:19:30 +0000 (18:19 -0400)
commitaf35d0639a335fe6422f9bca496d1a0d3e7b254f
treef5f470cbcdfc47ad670b27a6d0bcf60b43a3c8cf
parentcfdca1154f8215f1cb72f7cc29fd042a5ed32f47
cpufreq: qcom-hw: add CONFIG_COMMON_CLK dependency

[ Upstream commit 3093fa33539b54db77171d2919352ad4f044a1c5 ]

It is still possible to compile-test a kernel without CONFIG_COMMON_CLK
for some ancient ARM boards or other architectures, but this causes a
link failure in the qcom-cpufreq-hw driver:

ERROR: modpost: "devm_clk_hw_register" [drivers/cpufreq/qcom-cpufreq-hw.ko] undefined!
ERROR: modpost: "devm_of_clk_add_hw_provider" [drivers/cpufreq/qcom-cpufreq-hw.ko] undefined!
ERROR: modpost: "of_clk_hw_onecell_get" [drivers/cpufreq/qcom-cpufreq-hw.ko] undefined!

Add a Kconfig dependency here to make sure this always work. Apparently
this bug has been in the kernel for a while without me running into it
on randconfig builds as COMMON_CLK is almost always enabled.

I have cross-checked by building an allmodconfig kernel with COMMON_CLK
disabled, which showed no other driver having this problem.

Fixes: 4370232c727b ("cpufreq: qcom-hw: Add CPU clock provider support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/cpufreq/Kconfig.arm