]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
nfc: fix memory leak of se_io context in nfc_genl_se_io
authorFedor Pchelkin <pchelkin@ispras.ru>
Sat, 25 Feb 2023 10:56:14 +0000 (13:56 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 11 Mar 2023 15:31:59 +0000 (16:31 +0100)
commitaf452e35b9e6a87cd49e54a7a3d60d934b194651
treef2cea144b45fc697f48372363d3a6a7826e59cb4
parentd6d3599832b7c97130deffcd088af3e697f07cab
nfc: fix memory leak of se_io context in nfc_genl_se_io

[ Upstream commit 25ff6f8a5a3b8dc48e8abda6f013e8cc4b14ffea ]

The callback context for sending/receiving APDUs to/from the selected
secure element is allocated inside nfc_genl_se_io and supposed to be
eventually freed in se_io_cb callback function. However, there are several
error paths where the bwi_timer is not charged to call se_io_cb later, and
the cb_context is leaked.

The patch proposes to free the cb_context explicitly on those error paths.

At the moment we can't simply check 'dev->ops->se_io()' return value as it
may be negative in both cases: when the timer was charged and was not.

Fixes: 5ce3f32b5264 ("NFC: netlink: SE API implementation")
Reported-by: syzbot+df64c0a2e8d68e78a4fa@syzkaller.appspotmail.com
Signed-off-by: Fedor Pchelkin <pchelkin@ispras.ru>
Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/nfc/st-nci/se.c
drivers/nfc/st21nfca/se.c
net/nfc/netlink.c