]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
scsi: lpfc: Re-fix use after free in lpfc_rq_buf_free()
authorJames Smart <james.smart@broadcom.com>
Tue, 20 Oct 2020 20:27:13 +0000 (13:27 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 30 Dec 2020 10:26:15 +0000 (11:26 +0100)
commitaf5f1402b52be4d4b7b627f865e1d6b9fddc2f7d
tree09cd20d7fb5dbe48201126076dae450ce548afb2
parentb5ba762be4355d044948f0e27da240a7affcc6d4
scsi: lpfc: Re-fix use after free in lpfc_rq_buf_free()

commit e5785d3ec32f5f44dd88cd7b398e496742630469 upstream.

Commit 9816ef6ecbc1 ("scsi: lpfc: Use after free in lpfc_rq_buf_free()")
was made to correct a use after free condition in lpfc_rq_buf_free().
Unfortunately, a subsequent patch cut on a tree without the fix
inadvertently reverted the fix.

Put the fix back: Move the freeing of the rqb_entry to after the print
function that references it.

Link: https://lore.kernel.org/r/20201020202719.54726-4-james.smart@broadcom.com
Fixes: 411de511c694 ("scsi: lpfc: Fix RQ empty firmware trap")
Cc: <stable@vger.kernel.org> # v4.17+
Signed-off-by: James Smart <james.smart@broadcom.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/scsi/lpfc/lpfc_mem.c