]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
mount: Retest MNT_LOCKED in do_umount
authorEric W. Biederman <ebiederm@xmission.com>
Mon, 22 Oct 2018 15:21:38 +0000 (10:21 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 21 Nov 2018 08:22:08 +0000 (09:22 +0100)
commitafae7f7336d502e11437da66ec876c8c13a846ee
treeb2d9c75d6eedcee7f3beccbe1c74c91b25966a29
parente1d8594f10d14ffc2b1b6aea2a583280796a560c
mount: Retest MNT_LOCKED in do_umount

commit 25d202ed820ee347edec0bf3bf553544556bf64b upstream.

It was recently pointed out that the one instance of testing MNT_LOCKED
outside of the namespace_sem is in ksys_umount.

Fix that by adding a test inside of do_umount with namespace_sem and
the mount_lock held.  As it helps to fail fails the existing test is
maintained with an additional comment pointing out that it may be racy
because the locks are not held.

Cc: stable@vger.kernel.org
Reported-by: Al Viro <viro@ZenIV.linux.org.uk>
Fixes: 5ff9d8a65ce8 ("vfs: Lock in place mounts from more privileged users")
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/namespace.c