]> git.ipfire.org Git - thirdparty/linux.git/commit
selftest: net: fix socklen_t type mismatch in sctp_collision test
authorAnkit Khushwaha <ankitkhushwaha.linux@gmail.com>
Tue, 28 Oct 2025 17:29:47 +0000 (22:59 +0530)
committerJakub Kicinski <kuba@kernel.org>
Thu, 30 Oct 2025 00:39:26 +0000 (17:39 -0700)
commitafb8f6567a5b4bb4e673608048939fef854b8709
tree86a0baf73025d2a6c1c44ec08b4d6df14c19d159
parentefd3e30e651da21ac8a6bd83d24a92a948e1e7d3
selftest: net: fix socklen_t type mismatch in sctp_collision test

Socket APIs like recvfrom(), accept(), and getsockname() expect socklen_t*
arg, but tests were using int variables. This causes -Wpointer-sign
warnings on platforms where socklen_t is unsigned.

Change the variable type from int to socklen_t to resolve the warning and
ensure type safety across platforms.

warning fixed:

sctp_collision.c:62:70: warning: passing 'int *' to parameter of
type 'socklen_t *' (aka 'unsigned int *') converts between pointers to
integer types with different sign [-Wpointer-sign]
   62 |                 ret = recvfrom(sd, buf, sizeof(buf),
0, (struct sockaddr *)&daddr, &len);
      |                                                           ^~~~
/usr/include/sys/socket.h:165:27: note: passing argument to
parameter '__addr_len' here
  165 |                          socklen_t *__restrict __addr_len);
      |                                                ^

Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Signed-off-by: Ankit Khushwaha <ankitkhushwaha.linux@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20251028172947.53153-1-ankitkhushwaha.linux@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
tools/testing/selftests/net/netfilter/sctp_collision.c