]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
vhost: Take a reference on the task in struct vhost_task.
authorSebastian Andrzej Siewior <bigeasy@linutronix.de>
Thu, 18 Sep 2025 18:11:44 +0000 (20:11 +0200)
committerMichael S. Tsirkin <mst@redhat.com>
Sun, 21 Sep 2025 21:44:20 +0000 (17:44 -0400)
commitafe16653e05db07d658b55245c7a2e0603f136c0
tree3d0b4e6a3219818a4a676472d4851d04875437f3
parente430451613c7a27beeadd00d707bcf7ceec6328e
vhost: Take a reference on the task in struct vhost_task.

vhost_task_create() creates a task and keeps a reference to its
task_struct. That task may exit early via a signal and its task_struct
will be released.
A pending vhost_task_wake() will then attempt to wake the task and
access a task_struct which is no longer there.

Acquire a reference on the task_struct while creating the thread and
release the reference while the struct vhost_task itself is removed.
If the task exits early due to a signal, then the vhost_task_wake() will
still access a valid task_struct. The wake is safe and will be skipped
in this case.

Fixes: f9010dbdce911 ("fork, vhost: Use CLONE_THREAD to fix freezer/ps regression")
Reported-by: Sean Christopherson <seanjc@google.com>
Closes: https://lore.kernel.org/all/aKkLEtoDXKxAAWju@google.com/
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Message-Id: <20250918181144.Ygo8BZ-R@linutronix.de>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Tested-by: Sean Christopherson <seanjc@google.com>
kernel/vhost_task.c