]> git.ipfire.org Git - thirdparty/linux.git/commit
sched_ext: fix uninitialized ret on alloc_percpu() failure
authorLiang Jie <liangjie@lixiang.com>
Tue, 16 Dec 2025 09:39:55 +0000 (17:39 +0800)
committerTejun Heo <tj@kernel.org>
Tue, 16 Dec 2025 19:15:03 +0000 (09:15 -1000)
commitb0101ccb5b4641885f30fecc352ef891ed06e083
treedec9e0dabff67d95acf662aaa2e10a97ba33604f
parentbb27226f0d00588ac53be8825e021ae80aa43371
sched_ext: fix uninitialized ret on alloc_percpu() failure

Smatch reported:

  kernel/sched/ext.c:5332 scx_alloc_and_add_sched() warn: passing zero to 'ERR_PTR'

In scx_alloc_and_add_sched(), the alloc_percpu() failure path jumps to
err_free_gdsqs without initializing @ret. That can lead to returning
ERR_PTR(0), which violates the ERR_PTR() convention and confuses
callers.

Set @ret to -ENOMEM before jumping to the error path when
alloc_percpu() fails.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/r/202512141601.yAXDAeA9-lkp@intel.com/
Reported-by: Dan Carpenter <error27@gmail.com>
Fixes: c201ea1578d3 ("sched_ext: Move event_stats_cpu into scx_sched")
Signed-off-by: Liang Jie <liangjie@lixiang.com>
Reviewed-by: Emil Tsalapatis <emil@etsalapatis.com>
Reviewed-by: Andrea Righi <arighi@nvidia.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
kernel/sched/ext.c