]> git.ipfire.org Git - thirdparty/openssl.git/commit
REGRESSION: CMS_final: do not ignore CMS_dataFinal result
authorAlon Bar-Lev <alon.barlev@gmail.com>
Tue, 26 Jul 2022 05:53:48 +0000 (08:53 +0300)
committerHugo Landau <hlandau@openssl.org>
Thu, 28 Jul 2022 09:05:59 +0000 (10:05 +0100)
commitb03756130dadb3732b460a6efd930f1b226acdad
treefc48b7d68e46bd8c2fbb3048a83ab3b5d83303c6
parent38b051a1fedc79ebf24a96de2e9a326ad3665baf
REGRESSION: CMS_final: do not ignore CMS_dataFinal result

The CMS_dataFinal result is important as signature may fail, however, it
is ignored while returning success from CMS_final.

The SMIME_crlf_copy result is returned while it is ignored in the rest
of the openssl code.

Prefer the CMS_dataFinal result.

This is regression from openssl-1.

Blame finds c1669f41ei as root cause of regression.

Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Hugo Landau <hlandau@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/18876)
crypto/cms/cms_smime.c