]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
media: saa7146: fix array overflow in vidioc_s_audio()
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 17 Nov 2020 07:23:40 +0000 (08:23 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 30 Dec 2020 10:51:17 +0000 (11:51 +0100)
commitb0483a32d163b85f0afbd158ca5f8936cd3d8106
treebb774d89281222b1a1f8222b713c4e19a2236b1f
parentbfdf000e5dd92a97938446ba4524d659f3f1e533
media: saa7146: fix array overflow in vidioc_s_audio()

[ Upstream commit 8e4d86e241cf035d6d3467cd346e7ce490681937 ]

The "a->index" value comes from the user via the ioctl.  The problem is
that the shift can wrap resulting in setting "mxb->cur_audinput" to an
invalid value, which later results in an array overflow.

Fixes: 6680427791c9 ("[media] mxb: fix audio handling")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/media/pci/saa7146/mxb.c