]> git.ipfire.org Git - thirdparty/vim.git/commit
runtime(sh): Fix various syntax highlighting problems in ksh93 scripts
authorJohnothan King <johnothanking@protonmail.com>
Wed, 21 May 2025 19:21:14 +0000 (21:21 +0200)
committerChristian Brabandt <cb@256bit.org>
Wed, 21 May 2025 19:21:14 +0000 (21:21 +0200)
commitb0691b46bd684940efe2ebd56db0ca1c38b02a34
tree88080231b89f65508e845b8089588aec4de4ce1f
parent56b1207e66d8db82dabf3f36aadf24caea61aa71
runtime(sh): Fix various syntax highlighting problems in ksh93 scripts

- Fixed syntax highlighting for ksh93 namespace variables starting
  with '${.'
- Added support for the alarm, eloop, fds, mkservice, pids, poll and
  sha2sum builtins (which are indeed ksh93 builtins, albeit whether or
  not they are available depends on the ksh release and the compiled
  SHOPT options).
- Added support for the many Unix commands provided by ksh93's libcmd
  as builtin commands (since these are general commands, scripts for
  other shells like bash will also highlight these).
  - The dumps for the sh_0{2,5,6,8,9}.sh were recreated due to this
    change affecting commands those scripts call (e.g. 'wc').
- Enabled ${parameter/pattern/string} and friends for ksh syntax.
- Enabled case modification for ksh. See also:
  https://github.com/ksh93/ksh/commit/c1762e03
- Enabled ;;& support for ksh. See also:
  https://github.com/ksh93/ksh/commit/fc89d20a
- Added many special ksh variables using 93u+m's data/variables.c
  as a reference.

If vim can't figure out which ksh release is in play using e.g.
the hashbang path, in such a case a generic default that enables
everything and the kitchen sink will be used. Otherwise, features will
be disabled if it's absolutely known a certain feature will not be
present. Examples:
   - ERRNO is ksh88 specific, so that is locked to ksh88.
   - Only 93u+m (assumed for generic) has SRANDOM, and only 93u+m
     and 93v- have case modification support.
   - 93u+ and 93v- have VPATH and CSWIDTH variables (the latter
     is vestigal, but still present in the hardcoded variable table).
   - 93v- and ksh2020 have (buggy and near unusable) implementations
     of compgen and complete.
   - Only mksh provides function substitutions, i.e. ${|command;}.

This took the better part of my day to implement. It seems to work well
enough though. (Also had to regenerate the dumps again while testing
it, as now there are dup scripts with mere hashbang differences, used
solely for testing syntax highlighting differences.)

closes: #17348

Signed-off-by: Johnothan King <johnothanking@protonmail.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
96 files changed:
runtime/doc/syntax.txt
runtime/syntax/sh.vim
runtime/syntax/testdir/dumps/ksh2020_00.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/ksh2020_01.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/ksh2020_02.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/ksh2020_03.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/ksh2020_04.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/ksh2020_05.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/ksh2020_06.dump [moved from runtime/syntax/testdir/dumps/sh_10_00.dump with 64% similarity]
runtime/syntax/testdir/dumps/ksh2020_07.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/ksh2020_08.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/ksh2020_09.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/ksh88_00.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/ksh88_01.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/ksh88_02.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/ksh88_03.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/ksh88_04.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/ksh88_05.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/ksh88_06.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/ksh88_07.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/ksh88_08.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/ksh88_09.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/ksh93_generic_00.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/ksh93_generic_01.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/ksh93_generic_02.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/ksh93_generic_03.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/ksh93_generic_04.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/ksh93_generic_05.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/ksh93_generic_06.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/ksh93_generic_07.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/ksh93_generic_08.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/ksh93_generic_09.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/ksh93u_00.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/ksh93u_01.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/ksh93u_02.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/ksh93u_03.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/ksh93u_04.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/ksh93u_05.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/ksh93u_06.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/ksh93u_07.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/ksh93u_08.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/ksh93u_09.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/ksh93v_00.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/ksh93v_01.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/ksh93v_02.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/ksh93v_03.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/ksh93v_04.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/ksh93v_05.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/ksh93v_06.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/ksh93v_07.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/ksh93v_08.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/ksh93v_09.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/ksh_generic_00.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/ksh_generic_01.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/ksh_generic_02.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/ksh_generic_03.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/ksh_generic_04.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/ksh_generic_05.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/ksh_generic_06.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/ksh_generic_07.dump [moved from runtime/syntax/testdir/dumps/sh_10_01.dump with 53% similarity]
runtime/syntax/testdir/dumps/ksh_generic_08.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/ksh_generic_09.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/mksh_00.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/mksh_01.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/mksh_02.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/mksh_03.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/mksh_04.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/mksh_05.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/mksh_06.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/mksh_07.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/mksh_08.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/mksh_09.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/sh_02_01.dump
runtime/syntax/testdir/dumps/sh_05_00.dump
runtime/syntax/testdir/dumps/sh_05_01.dump
runtime/syntax/testdir/dumps/sh_05_02.dump
runtime/syntax/testdir/dumps/sh_06_00.dump
runtime/syntax/testdir/dumps/sh_08_00.dump
runtime/syntax/testdir/dumps/sh_08_01.dump
runtime/syntax/testdir/dumps/sh_08_02.dump
runtime/syntax/testdir/dumps/sh_08_03.dump
runtime/syntax/testdir/dumps/sh_09_00.dump
runtime/syntax/testdir/dumps/sh_10_02.dump [deleted file]
runtime/syntax/testdir/dumps/sh_bash_sundrous_00.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/sh_bash_sundrous_01.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/sh_bash_sundrous_02.dump [new file with mode: 0644]
runtime/syntax/testdir/dumps/sh_bash_sundrous_03.dump [new file with mode: 0644]
runtime/syntax/testdir/input/ksh2020.ksh [new file with mode: 0644]
runtime/syntax/testdir/input/ksh88.ksh [new file with mode: 0644]
runtime/syntax/testdir/input/ksh93_generic.ksh [new file with mode: 0644]
runtime/syntax/testdir/input/ksh93u.ksh [new file with mode: 0644]
runtime/syntax/testdir/input/ksh93v.ksh [new file with mode: 0644]
runtime/syntax/testdir/input/ksh_generic.ksh [new file with mode: 0644]
runtime/syntax/testdir/input/mksh.ksh [new file with mode: 0644]
runtime/syntax/testdir/input/sh_10.sh [deleted file]
runtime/syntax/testdir/input/sh_bash_sundrous.bash [new file with mode: 0644]