]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net/ncsi: fix locking in Get MAC Address handling
authorPaul Fertser <fercerpav@gmail.com>
Thu, 9 Jan 2025 14:50:54 +0000 (17:50 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 21 Feb 2025 12:49:35 +0000 (13:49 +0100)
commitb0a199accf8f650abaf0ec9956e398506a05c43c
tree1f5905993951c2d4c1bede72022fe7011e4c103d
parentae0cd719883edf0a0789cb9c74dcd04e568a2020
net/ncsi: fix locking in Get MAC Address handling

[ Upstream commit 9e2bbab94b88295dcc57c7580393c9ee08d7314d ]

Obtaining RTNL lock in a response handler is not allowed since it runs
in an atomic softirq context. Postpone setting the MAC address by adding
a dedicated step to the configuration FSM.

Fixes: 790071347a0a ("net/ncsi: change from ndo_set_mac_address to dev_set_mac_address")
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/20241129-potin-revert-ncsi-set-mac-addr-v1-1-94ea2cb596af@gmail.com
Signed-off-by: Paul Fertser <fercerpav@gmail.com>
Tested-by: Potin Lai <potin.lai.pt@gmail.com>
Link: https://patch.msgid.link/20250109145054.30925-1-fercerpav@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/ncsi/internal.h
net/ncsi/ncsi-manage.c
net/ncsi/ncsi-rsp.c