]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
pwm: spear: Don't modify HW state in .remove callback
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Wed, 28 Apr 2021 09:05:24 +0000 (11:05 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 20 Jul 2021 14:22:42 +0000 (16:22 +0200)
commitb0c7c46e09f52cf36c55f70ca7b292b095de4f0b
treed5a7599400323b5f2850d147fd7c70b079f793e4
parent61813d1642cc92b554b0494e10358c0c2b272d6c
pwm: spear: Don't modify HW state in .remove callback

[ Upstream commit b601a18f12383001e7a8da238de7ca1559ebc450 ]

A consumer is expected to disable a PWM before calling pwm_put(). And if
they didn't there is hopefully a good reason (or the consumer needs
fixing). Also if disabling an enabled PWM was the right thing to do,
this should better be done in the framework instead of in each low level
driver.

So drop the hardware modification from the .remove() callback.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/pwm/pwm-spear.c