]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
usb: core: hcd: fix accessing unmapped memory in SINGLE_STEP_SET_FEATURE test
authorXu Yang <xu.yang_2@nxp.com>
Wed, 6 Aug 2025 08:39:55 +0000 (16:39 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 28 Aug 2025 14:31:09 +0000 (16:31 +0200)
commitb0cdcacd9174284d0aa411cd50b0d45d9867b09c
tree9b6e2a927a0f747eeca6dd88dbfdc598b8b12812
parentf3b0c9ec54736f3b8118f93a473d22e11ee65743
usb: core: hcd: fix accessing unmapped memory in SINGLE_STEP_SET_FEATURE test

commit 8fe06185e11ae753414aa6117f0e798aa77567ff upstream.

The USB core will unmap urb->transfer_dma after SETUP stage completes.
Then the USB controller will access unmapped memory when it received
device descriptor. If iommu is equipped, the entire test can't be
completed due to the memory accessing is blocked.

Fix it by calling map_urb_for_dma() again for IN stage. To reduce
redundant map for urb->transfer_buffer, this will also set
URB_NO_TRANSFER_DMA_MAP flag before first map_urb_for_dma() to skip
dma map for urb->transfer_buffer and clear URB_NO_TRANSFER_DMA_MAP
flag before second map_urb_for_dma().

Fixes: 216e0e563d81 ("usb: core: hcd: use map_urb_for_dma for single step set feature urb")
Cc: stable <stable@kernel.org>
Reviewed-by: Jun Li <jun.li@nxp.com>
Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Link: https://lore.kernel.org/r/20250806083955.3325299-1-xu.yang_2@nxp.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/core/hcd.c