]> git.ipfire.org Git - thirdparty/linux.git/commit
resolve_btfids: Fix linker flags detection
authorIhor Solodrai <ihor.solodrai@linux.dev>
Thu, 5 Mar 2026 01:47:30 +0000 (17:47 -0800)
committerAlexei Starovoitov <ast@kernel.org>
Sat, 7 Mar 2026 16:51:51 +0000 (08:51 -0800)
commitb0dcdcb9ae757c8a8ba2fb24d34f8d147bae707b
treed9a12fe3b9f35ec21c296342fcfdc94c1da4cca4
parent325d1ba3cac4a1c0bf981f73f4edbb7411f0e4dc
resolve_btfids: Fix linker flags detection

The "|| echo -lzstd" default makes zstd an unconditional link
dependency of resolve_btfids. On systems where libzstd-dev is not
installed and pkg-config fails, the linker fails:

  ld: cannot find -lzstd: No such file or directory

libzstd is a transitive dependency of libelf, so the -lzstd flag is
strictly necessary only for static builds [1].

Remove ZSTD_LIBS variable, and instead set LIBELF_LIBS depending on
whether the build is static or not. Use $(HOSTPKG_CONFIG) as primary
source of the flags list.

Also add a default value for HOSTPKG_CONFIG in case it's not built via
the toplevel Makefile. Pass it from selftests/bpf too.

[1] https://lore.kernel.org/bpf/4ff82800-2daa-4b9f-95a9-6f512859ee70@linux.dev/

Reported-by: BPF CI Bot (Claude Opus 4.6) <bot+bpf-ci@kernel.org>
Reported-by: Vitaly Chikunov <vt@altlinux.org>
Closes: https://lore.kernel.org/bpf/aaWqMcK-2AQw5dx8@altlinux.org/
Fixes: 4021848a903e ("selftests/bpf: Pass through build flags to bpftool and resolve_btfids")
Signed-off-by: Ihor Solodrai <ihor.solodrai@linux.dev>
Reviewed-by: Paul Chaignon <paul.chaignon@gmail.com>
Link: https://lore.kernel.org/r/20260305014730.3123382-1-ihor.solodrai@linux.dev
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
tools/bpf/resolve_btfids/Makefile
tools/testing/selftests/bpf/Makefile